[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uncommented code in LilyPond
From: |
David Kastrup |
Subject: |
Re: Uncommented code in LilyPond |
Date: |
Mon, 03 Sep 2012 17:34:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) |
Janek Warchoł <address@hidden> writes:
> On Mon, Sep 3, 2012 at 1:00 PM, Graham Percival
> <address@hidden> wrote:
>> I think that any time that a LilyPond developer complains that
>> the code is too hard to understand, the patch should automatically
>> move to Patch-needs_work. Automatically.
>> If there's a long discussion and there's overwhelming opinion from
>> other developers that the code is fine, then we could ignore the
>> dissenting developer. But unless there's *overwhelming* opinion
>> that the patch is fine, I think that a single complaint of
>> readability should render the patch un-pushable.
>
> +1.
> Hmm, adopting this policy would make me the most feared reviewer in
> the community :-P
Shrug. It is life insurance with the code as benefiter. Nobody wants
to pay the premium, but if you don't, it won't survive for long after
you lose life or just interest in it.
--
David Kastrup
- gerrit - does it allow writing commits using a web interface?, Janek Warchoł, 2012/09/02
- Re: gerrit - does it allow writing commits using a web interface?, David Kastrup, 2012/09/03
- Uncommented code in LilyPond, address@hidden, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/03
- Re: Uncommented code in LilyPond,
David Kastrup <=
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/04
- Re: Uncommented code in LilyPond, Rodolfo Zitellini, 2012/09/04
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/04
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/04
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/03
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03