[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skyline
From: |
dak |
Subject: |
Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077) |
Date: |
Tue, 11 Sep 2012 20:52:34 +0000 |
http://codereview.appspot.com/6498077/diff/6033/lily/phrasing-slur-engraver.cc
File lily/phrasing-slur-engraver.cc (right):
http://codereview.appspot.com/6498077/diff/6033/lily/phrasing-slur-engraver.cc#newcode116
lily/phrasing-slur-engraver.cc:116: Grob *stub = make_spanner
("SlurStub", info.grob ()->self_scm ());
Why do you use the NoteColumn here as the cause for the SlurStub? It
would make much more sense to use the respective slur. Then you don't
need a separate "surrogate" field since you can just use 'cause instead,
and you can \tweak a SlurStub via its Slur event, and most importantly
you don't need a special "initialize from surrogate" utility function
but can rather use an "initialize from cause" function.
http://codereview.appspot.com/6498077/
- Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077), (continued)
Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077), k-ohara5a5a, 2012/09/10
Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077),
dak <=
Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077), k-ohara5a5a, 2012/09/22