[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bar-line interface part 2/2: New bar line definition standard (issue
From: |
k-ohara5a5a |
Subject: |
Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052) |
Date: |
Sat, 29 Sep 2012 05:11:46 +0000 |
Looks good so far.
In one pdf previewer (evince) at low resolution, the span bars look a
little thicker than the regular bar lines. Maybe a rounding fault of
the viewer, but it would be better if you know how to avoid it.
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm#newcode953
scm/bar-line.scm:953: (ly:grob-property right-bar-line 'glyph-name)))
Sometimes I get a crash that I traced back to a null -- that is, '() --
left-bar-glyph-name here. The piece in question has a repeat
alternative that starts a on new line.
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm#newcode1029
scm/bar-line.scm:1029:
;; "normal bar -annotation" "end of line" "start of line" "span bar"
http://codereview.appspot.com/6498052/
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052), ianhulin44, 2012/09/27
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052), thomasmorley65, 2012/09/27
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052),
k-ohara5a5a <=
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052), k-ohara5a5a, 2012/09/29
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052), k-ohara5a5a, 2012/09/29
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052), dak, 2012/09/30
- Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052), dak, 2012/09/30