Re: Python hacker emergency on git-cl

[David Kastrup]

James <address@hidden> writes:

> Hello,
>
> On 1 December 2012 17:24, Reinhold Kainhofer <address@hidden> wrote:
>> On 2012-12-01 17:12, David Kastrup wrote:> My interpretation is that Google
>> has set codereview.appspot.com so that
>>> any http request will automatically get redirected to https, and git-cl
>>> is unable to deal with that.
>>
>> Well, git-cl (I would prefer git-cly to indicate this is not the standard
>> git-cl, but a modified version for use with lilypond!) uses Google's
>> upload.py script, which is able to handle https properly.
>>
>>
>>> It is unlikely that this is going to change on Google's side, so until
>>> somebody gets git-cl able to deal with that, our workflow is hosed.
>>
>> It's actually quite simple:
>> https://codereview.appspot.com/6864043/
>>
>> All I did was download the latest upload.py from the rietveld help page and
>> adjust the changed command line arguments...
>>
>>> Any Python hackers willing or able to take this on?
>>
>> Absolutely no python needed...
>>
>
> Obviously patchy cannot test this patch.
>
> So we're going to need to test this and verify this some other way.

Well, I have been using it already, and it is clearly an improvement
over the previous situation, so it should be committed to git-cl, and
people should be encouraged to update their version of git-cl afterwards
(well, that it does not work otherwise is likely "encouragement"
enough).

-- 
David Kastrup