Re: Doc: cautionary accidentals after a key change (3000) (issue 6872049)

[k-ohara5a5a]

Looks nice.
Maybe make it shorter, if you want.


https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3301
Documentation/notation/changing-defaults.itely:3301: cautionary
accidentals printed at an explicit key change when
"does not remove the naturals printed at a key change if these naturals
are the only indication of the change:"

I did not recognize the naturals as 'cautionary'.  The clause with
"since that" overwhelmed my English-grammar comprehension.

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3318
Documentation/notation/changing-defaults.itely:3318: the visibility of
the @code{KeyCancellation} grob itself:
You might want to combine these two examples into one, with all the text
above, so that the space given to this detail is not so excessive.

I love the second person imperative.  (Please don't change it to "the
visibility can be overridden" just because I pointed it out.)

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3324
Documentation/notation/changing-defaults.itely:3324: \override
Staff.KeyCancellation.break-visibility = #all-invisible
On 2012/12/03 06:00:15, dak wrote:
> Why not use \omit Staff.KeyCancellation here?
All the other examples use 'break-visibility, so it would be puzzling if
this one were done differently.

https://codereview.appspot.com/6872049/