|
| From: | dak |
| Subject: | Re: \note-by-number supports flag-styles (issue 7231072) |
| Date: | Sat, 02 Feb 2013 16:11:19 +0000 |
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#newcode3366
scm/define-markup-commands.scm:3366: (string-append "flags."
I'd rather use
(format #f (if ancient-flags? "flags.mensural~a2~a"
"flags.~a~a")
(if (> dir 0) "u" "d") log)
here. It is somewhat more readable.
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#newcode3387
scm/define-markup-commands.scm:3387: (or (eq? flag-style 'default)
(list? flag-style))
Why (list? flag-style)? Is that a tricky obfuscation of (null?
flag-style)?
https://codereview.appspot.com/7231072/
| [Prev in Thread] | Current Thread | [Next in Thread] |