[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: \note-by-number supports flag-styles (issue 7231072)
|
From: |
thomasmorley65 |
|
Subject: |
Re: \note-by-number supports flag-styles (issue 7231072) |
|
Date: |
Sun, 03 Feb 2013 14:09:17 +0000 |
Don't know why two identical patch-sets were uploaded
On 2013/02/02 16:11:19, dak wrote:
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#newcode3366
scm/define-markup-commands.scm:3366: (string-append "flags."
I'd rather use
(format #f (if ancient-flags? "flags.mensural~a2~a"
"flags.~a~a")
(if (> dir 0) "u" "d") log)
here. It is somewhat more readable.
Changed.
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm#newcode3387
scm/define-markup-commands.scm:3387: (or (eq? flag-style 'default)
(list?
flag-style))
Why (list? flag-style)? Is that a tricky obfuscation of (null?
flag-style)?
Rather bad thinking.
Changed.
https://codereview.appspot.com/7231072/