Re: Avoid excessive number of dots in chords (#3179). (issue 7319049)

[lemzwerg]

Thanks for the review.


https://codereview.appspot.com/7319049/diff/2001/lily/dot-column.cc
File lily/dot-column.cc (right):

https://codereview.appspot.com/7319049/diff/2001/lily/dot-column.cc#newcode63
lily/dot-column.cc:63: vector<Interval> allowed_y_positions;
On 2013/02/17 08:20:39, Keith wrote:
> It would be simpler to have just one interval, describing all the dots
handled
> by one dot_engraver, even if coming from two voices.

I've started with a single interval but this doesn't work well.  Just
imagine

  << { <e f g a b>2. } \\
     { <c, d e f g>2. } >>

There is a gap between the two clusters, and it looks really strange if
this is filled with dots.

https://codereview.appspot.com/7319049/diff/2001/lily/dot-column.cc#newcode80
lily/dot-column.cc:80: Interval hp = Stem::head_positions (stem);
On 2013/02/17 08:20:39, Keith wrote:
> It looks like head_positions are shifted in the test 'grid-lines.ly'
but dot
> positions are not, at this stage in the code.

This is addressed in the newer patchset.

https://codereview.appspot.com/7319049/