Re: Caches the interior skylines of vertical axis groups and systems.(issue 7185044)

[address@hidden]

On 19 févr. 2013, at 16:11, Trevor Daniels <address@hidden> wrote:

> 
> From: <address@hidden>
> Sent: Monday, February 18, 2013 8:32 PM
> 
>> On 18 févr. 2013, at 20:07, address@hidden wrote:
>> 
>>> You can't just throw functionality overboard when you are "improving"
>>> things and tell people they have to revert to the old code if they
>>> care about that functionality.  After all, it is totally unclear how
>>> elements with the old callbacks and elements with the new
>>> outside-staff-priority ignoring callbacks will even combine.
>> 
>> It is true that this breaks old functionality for user overrides.
>> 
>> The goal is certainly not to mask things.  I will make sure to put this in 
>> the change log and will write a not-smart convert-ly rule in my next patch 
>> set.
> 
> That's not good enough.  The present overrides of outside-staff-priority
> figure quite extensively in the user documentation.  This will all need to be
> re-written as part of an acceptable patch to show users how to rearrange
> the order in which outside-staff objects are placed.
> 
> Trevor

Hey Trevor,

Thanks for giving me input from a documentation point of view.  When writing 
the patch, this was one of the fundamental things I took into account.  All of 
the examples in the notation reference, learning manual and snippets show no 
change with this patch applied.

The current documentation on outside-staff grobs reads: "Intuitively, there are 
some objects in musical notation that belong to the staff and there are other 
objects that should be placed outside the staff. Objects belonging outside the 
staff include things such as rehearsal marks, text and dynamic markings (from 
now on, these will be called outside-staff objects). LilyPond’s rule for the 
vertical placement of outside-staff objects is to place them as close to the 
staff as possible but not so close that they collide with another object."

If we accept this definition of outside-staff grobs, then this patch correctly 
typesets all outside staff grobs.  The main thing this patch effects are 
esoteric grobs that normally don't get outside-staff-priority, like 
MultiMeasureRest, NoteHeads and Rests.

In light of this, what type of additions to the NR do you feel would be 
necessary to indicate the new behavior?

Cheers,
MS