|
From: | tdanielsmusic |
Subject: | Re: rewrite Self_alignment_interface (issue 7768043) |
Date: | Wed, 03 Apr 2013 17:12:14 +0000 |
Code not tested or even eye-balled. https://codereview.appspot.com/7768043/diff/76001/input/regression/text-spanner-attachment-alignment.ly File input/regression/text-spanner-attachment-alignment.ly (right): https://codereview.appspot.com/7768043/diff/76001/input/regression/text-spanner-attachment-alignment.ly#newcode21 input/regression/text-spanner-attachment-alignment.ly:21: \repeat unfold 2 {c'4 _ \markup { "FAT" } } What does (1 . -1) do? I saw nothing in any of the commit messages about changing the user interface (but they are so long maybe I missed it) https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly File input/regression/unassociated-lyrics-alignment.ly (right): https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly#newcode12 input/regression/unassociated-lyrics-alignment.ly:12: \new Lyrics { \lyricmode { foo2 bar aaa1 mmm1 } } I see the durations on the syllables are the same as those on the notes. What happens if they differ? In particular if a syllable is placed between two notes? https://codereview.appspot.com/7768043/diff/76001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/7768043/diff/76001/scm/define-grob-properties.scm#newcode807 scm/define-grob-properties.scm:807: @code{'(-1 . 1)} will result in grobs' left edge being aligned to OK, I understand now. https://codereview.appspot.com/7768043/
[Prev in Thread] | Current Thread | [Next in Thread] |