|
From: | janek . lilypond |
Subject: | skyline.cc: No zero-width empty buildings between buildings; issue 3311 (issue 8668044) |
Date: | Sat, 13 Apr 2013 11:27:29 +0000 |
LGTM this is much clearer (and i think also better) than Mike's patch. https://codereview.appspot.com/8668044/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/8668044/diff/1/lily/skyline.cc#newcode389 lily/skyline.cc:389: if (x1 > last_end) I suggest to add a comment: "Avoid creating zero-width empty buildings" https://codereview.appspot.com/8668044/
[Prev in Thread] | Current Thread | [Next in Thread] |