Re: Add the command \offset to LilyPond (issue 8647044)

[david . nalesnik]

On 2013/04/23 19:38:09, dak wrote:
> On 2013/04/23 19:03:18, david.nalesnik wrote:
> > On 2013/04/23 13:14:23, janek wrote:
> > > anyway, this patch LTGM.
> >
> > Thanks, Janek!
> >
> > The patch has passed countdown, but in view of the fact that a
stable release
> is
> > on the horizon, it may not be appropriate to push it at this time.
> >
> > On the other hand, an argument for pushing it right away might be to
guard it
> > against loss of functionality, as happened recently regarding
Stem.length and
> > Y-offset for certain grobs.

> Huh?  I don't understand that argument.

I mean simply that future changes would need to take the functionality
of \offset into account.  There's no real guarantee that something isn't
going to be pushed between the present and the date the the stable
release actually comes out that won't affect it.

On the other hand, the patch is missing
> a Changes entry and any integration into the user documentation, so it
is mostly
> inaccessible to users anyway (and the means to discuss/review its
interface
> design are limited) and there seems little point to include it in this
state.
> If we don't have documentation for the next unstable release, the
chances for
> translations etc to arrive timely are slim.

I'm not entirely clear what you mean here.  Are you saying that the
patch should be withdrawn and resubmitted with full documentation--if it
is to be considered for the _stable_ release?

Thanks,
David



https://codereview.appspot.com/8647044/