|
| From: | dak |
| Subject: | Re: Add the command \offset to LilyPond (issue 8647044) |
| Date: | Tue, 23 Apr 2013 20:24:57 +0000 |
Sorry for the late review.
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5
input/regression/offsets.ly:5: the @code{\\offset} command. These
properties are limited to immutable
What does "immutable" mean here?
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode8
input/regression/offsets.ly:8: in its default appearance. The command
is used both as a tweak and an
"demonstrated as a tweak and as an override". The double "as" is
important, and I'd remove "both" since otherwise the impression arises
that it is both at the same time.
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm
File scm/c++.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm#newcode30
scm/c++.scm:30: (every number-pair? x)))
Isn't it dangerous to call "every" on something that is not necessarily
a list? Like (cons 2 3)?
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm#newcode2103
scm/music-functions.scm:2103: ; head of the alist. We reverse the alist
so our search will return
Why would tweak/override add to the _immutable_ properties? How could
they? Is there something I don't understand here?
https://codereview.appspot.com/8647044/
| [Prev in Thread] | Current Thread | [Next in Thread] |