Re: parser.yy: allow "scalar" to be a negative literal number (issue 13270048)

[lemniskata . bernoullego]

On 2013/09/01 16:49:59, dak wrote:
> https://codereview.appspot.com/13270048/diff/1/lily/parser.yy
> File lily/parser.yy (right):


https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2328
> lily/parser.yy:2328: | SCM_IDENTIFIER
> On 2013/09/01 16:25:39, Janek Warchol wrote:
> > just curious: this SCM_IDENTIFIER is for things like #LEFT?

> No.  It's for \xxx or $xxx kind of things not belonging in any other
> xxx_IDENTIFIER category.  #LEFT would be SCM_TOKEN instead (and is
covered by
> embedded_scm_arg).

ah,ok.


https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2351
> lily/parser.yy:2351: // not of the kind requiring the full closedness
folderol.
> On 2013/09/01 16:25:39, Janek Warchol wrote:
> > Please avoid using uncommon words like "folderol".  They are funny,
but only
> for
> > native speakers ;-)

> The dictionary offers "humbug", "balderdash", "poppycock", "rubbish",
"tripe",
> "trumpery", "trash", "wish-wash", "applesauce", "codswallop" as
alternative
> words but most of them have not quite the same connotations, and it's
not like
> those that are similar in meaning are in more common use.

uh, ok.

> While most code passages in LilyPond are documented without venturing
beyond the
> most common 1000 English words (mostly because they are not venturing
beyond any
> word at all), I think this should already be a notable improvement
over the
> standard state.

Indeed, i've noticed the extensive comments and i do appreciate them!

Janek

https://codereview.appspot.com/13270048/