lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Keep bison-generated files in sync. (issue 13466043)


From: julien . rioux
Subject: Re: Keep bison-generated files in sync. (issue 13466043)
Date: Mon, 02 Sep 2013 17:59:43 +0000

See http://code.google.com/p/lilypond/issues/detail?id=3528


https://codereview.appspot.com/13466043/diff/2001/stepmake/stepmake/c++-rules.make
File stepmake/stepmake/c++-rules.make (right):

https://codereview.appspot.com/13466043/diff/2001/stepmake/stepmake/c++-rules.make#newcode16
stepmake/stepmake/c++-rules.make:16: $(BISON) -o $(subst .hh,.cc,$@) -d
$<
On 2013/09/02 17:46:15, dak wrote:
Han-Wen's version was slightly different:

        $(BISON) -d -o $(subst .hh,.cc,$@)  $<

but I don't consider it graceful.  I'd try

        $(BISON) -d -o $*.cc  $<

instead.  I _think_ this should take the right directory.

The ordering of -d and -o options doesn't matter, so it was exactly the
same. We can use $* if you prefer, but let's not forget the output dir,
so
$(BISON) -d -o $(outdir)/$*.cc $<
OK?

https://codereview.appspot.com/13466043/diff/2001/stepmake/stepmake/c-rules.make
File stepmake/stepmake/c-rules.make (right):

https://codereview.appspot.com/13466043/diff/2001/stepmake/stepmake/c-rules.make#newcode16
stepmake/stepmake/c-rules.make:16: $(BISON) -o $(subst .h,.c,$@) -d $<
On 2013/09/02 17:46:15, dak wrote:
Do we need this rule at all?  We don't have .y files in the tree and
the only
actual C file would appear to be python/midi.c anyway.

It is part of stepmake, and it is conceivable (although I wouldn't wish
it on anyone) that somebody has decided to use stepmake for their own
project. (lilypond doesn't use this rule)

https://codereview.appspot.com/13466043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]