lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Stop \lyricmode { \skip 1.*3 } from failing. (issue 13256053)


From: David Kastrup
Subject: Re: Stop \lyricmode { \skip 1.*3 } from failing. (issue 13256053)
Date: Mon, 23 Sep 2013 18:59:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Vik Reykja <address@hidden> writes:

> On Mon, Sep 23, 2013 at 8:50 AM, <address@hidden> wrote:
>
>> On 2013/09/22 22:30:51, Vik Reykja wrote:
>>
>>> I think a patch like this requires at least one regression test.
>>>
>>
>> Well, actually the original lexer.ll patch would more likely have called
>> for a regression test as it covers a lot more change.
>>
>
> Well sure, but that ship sailed a year ago.

We're still phoning ships about hull leaks that sailed almost a decade
ago.  One would have thought they'd never make it out of port, but
people seem to be used to the bilge pump.

>> Would you want to propose one?  A sole \lyricmode { \skip 1.*3 }
>> seems a bit flimsy.
>>
>
> I'm still very much a lilypond newcomer, and I don't have much
> knowledge about lexers, so I don't really know what else that
> refactoring could have affected.  I found one construct that it broke
> and I don't think that including a regtest in the fix so it doesn't
> happen again is flimsy.

Hm.

-- 
David Kastrup



reply via email to

[Prev in Thread] Current Thread [Next in Thread]