[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Use built-in make functions for finding absolute paths. (issue 97510043)
From: |
hanwenn |
Subject: |
Use built-in make functions for finding absolute paths. (issue 97510043) |
Date: |
Fri, 16 May 2014 09:05:23 +0000 |
Reviewers: ,
Message:
please review.
Description:
Use built-in make functions for finding absolute paths.
Please review this at https://codereview.appspot.com/97510043/
Affected files (+4, -10 lines):
M stepmake/stepmake/generic-vars.make
Index: stepmake/stepmake/generic-vars.make
diff --git a/stepmake/stepmake/generic-vars.make
b/stepmake/stepmake/generic-vars.make
index
b0fc521e931334a8f4c25867658fe183df7c4b7c..fb75166e1ba61c35d0b1ad7e51237df30567bcfb
100644
--- a/stepmake/stepmake/generic-vars.make
+++ b/stepmake/stepmake/generic-vars.make
@@ -1,9 +1,7 @@
-top-build-dir = $(shell cd $(depth) && pwd)
-build-dir = $(shell cd . && pwd)
-tree-dir = $(subst $(top-build-dir),,$(build-dir))
-
-absdir = $(shell cd $(1) ; pwd)
+top-build-dir := $(realpath $(depth) )
+build-dir := $(realpath . )
+tree-dir = $(subst $(top-build-dir),,$(build-dir))
ifneq ($(configure-srcdir),.)
srcdir-build = 1
@@ -15,7 +13,7 @@ else
src-depth = $(configure-srcdir)
endif
-top-src-dir := $(shell cd $(src-depth); pwd)
+top-src-dir := $(realpath $(src-depth))
ifndef srcdir-build
src-dir = .
@@ -46,10 +44,6 @@ DEPTH = $(depth)/$(package-depth)
INSTALLPY=$(buildscript-dir)/install -c
INSTALL=$(INSTALLPY)
-group-dir = $(shell cd $(DEPTH);pwd)/..
-patch-dir = $(group-dir)/patches
-rpm-sources = $(release-dir)
-rpm-build = $(group-dir)/RedHat/BUILD
package-icon = $(outdir)/$(package)-icon.xpm
ifneq ($(strip $(MY_PATCH_LEVEL)),)
- Use built-in make functions for finding absolute paths. (issue 97510043),
hanwenn <=