Re: Reposition voiced rests (Issue 3902) (issue 101720045)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Tuesday, May 27, 2014 10:59 AM
Subject: Re: Reposition voiced rests (Issue 3902) (issue 101720045)


> On 2014/05/27 09:38:11, PhilEHolmes wrote:
> > Please review
>
> According to the comparison images in
> https://code.google.com/p/lilypond/issues/detail?id=3902#c5 this is
> definitely an improvement. (I had looked for that issue myself, but I
> have to admit that I have to stop when entering the C++ area ...).
>
> But what would you think about going one step further and place voiced
> rests by default at the same position as \oneVoice rests? This would
> make the regularly asked question about merging rests obsolete. The rest
> would appear identical to a \oneVoice rest if there isn't any other
> object in the way. The voice number assignment would then "only"
> determine the direction the rests would move to.

I would definitely argue against that.  I frequently want separated rests 
for separate voices, and to remove that would not match the recomended 
typesetting procedure.  If I wanted "merged" rests, I'd just spacer-rest one 
of them and use \voiceOne.

> Another approach which would be an even more significant improvement
> (but definitely much more involved) would be to try to determine pitches
> of surrounding notes in the same voice, which can avoid ambiguities
> sometimes.
> (Maybe it's a good idea to reread
> http://blog.steinberg.net/2014/02/development-diary-part-the-fifth/#more-523)
> which was my first encounter of the problem).
>
> Please note that these are only suggestions, no objections against the
> patch.
>
> https://codereview.appspot.com/101720045/

I'm starting with something very simple here, so that's too complex at my 
stage of understanding.  If you look at all the comments on the issue, 
you'll see my disquiet over the misplaced ledger lines.  That will likely be 
a new issue that I may work on later.

--
Phil Holmes