Re: Reposition voiced rests (Issue 3902) (issue 101720045)

[david . nalesnik]

On 2014/05/27 14:27:07, email_philholmes.net wrote:
> ----- Original Message -----
> From: <mailto:address@hidden>
> To: <mailto:address@hidden>;
<mailto:address@hidden>;
> <mailto:address@hidden>; <mailto:address@hidden>;
<mailto:address@hidden>
> Cc: <mailto:address@hidden>;
<mailto:address@hidden>
> Sent: Tuesday, May 27, 2014 3:12 PM
> Subject: Re: Reposition voiced rests (Issue 3902) (issue 101720045)


> >
> > https://codereview.appspot.com/101720045/diff/1/lily/rest.cc
> > File lily/rest.cc (right):
> >
> >
https://codereview.appspot.com/101720045/diff/1/lily/rest.cc#newcode138
> > lily/rest.cc:138:
> > To be consistent with your change above, shouldn't this be:
> >
> >   return neutral + 2 * dir;
> >
> > https://codereview.appspot.com/101720045/


> Probably.  I can't think of a use case where this code would actually
be
> exercised, so would welcome a suggestion.

> --
> Phil Holmes


It appears that this is a check that the automatic calculations of the
positions of voiced half and whole rests are sensible.  The check can
fail when you mess with the number of staff lines, in which case the
fallback is assigned.

Hmm.  It doesn't appear that I can attach anything here, so I'll have to
give my examples (before and after with the revised line) on the page
for Issue 3902.


https://codereview.appspot.com/101720045/