|
| From: | dak |
| Subject: | Re: Issue 3935: Use (pretty-print) for some IR props. (issue 95710044) |
| Date: | Fri, 30 May 2014 08:38:23 +0000 |
https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm File scm/documentation-lib.scm (right): https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm#newcode112 scm/documentation-lib.scm:112: (or (vector? val) ; vector is an ly-type Comment makes no sense. https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm#newcode138 scm/documentation-lib.scm:138: (lambda (port) (pretty-print val port #:display? #t)) Wouldn't #:display? #t show a partial value of "string" as string without quotes? The examples in the issue report don't contain strings, so it's hard to guess. https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm#newcode144 scm/documentation-lib.scm:144: (string-regexp-substitute "\n " "\n " str))) pretty-print has a key #:per-line-prefix. Would that be easier to use? https://codereview.appspot.com/95710044/
| [Prev in Thread] | Current Thread | [Next in Thread] |