Re: Issue 3254: align unassociated lyrics using NoteColumn extent. (issue 108110044 by address@hidden)

[janek . lilypond]

Thanks for review!


https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc
File lily/paper-column.cc (right):

https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc#newcode226
lily/paper-column.cc:226: Paper_column::get_generic_interface_extent
(Grob *column, SCM interface, Axis a)
On 2014/06/24 05:41:52, Keith wrote:
> I don't understand what 'generic' means over just
get_interface_extent(c, i, a)
> but I leave it to you to name your function.

Hmm.  Maybe i'll indeed change it to get_interface_extent.

https://codereview.appspot.com/108110044/diff/80001/lily/self-alignment-interface.cc
File lily/self-alignment-interface.cc (right):

https://codereview.appspot.com/108110044/diff/80001/lily/self-alignment-interface.cc#newcode82
lily/self-alignment-interface.cc:82: MAKE_SCHEME_CALLBACK
(Self_alignment_interface, centered_on_note_columns, 1);
On 2014/06/24 05:41:53, Keith wrote:
> Looks like somebody had a similar idea.  This function seems to be
used only for
> dynamics in a Dynamics context.

Good catch!  Indeed, in the next patch I'm cleaning up dynamics
alignment so that it uses the newly improved aligned_on_parent
everywhere instead of having multiple alignment callbacks (some of them
hardcoded in C++).  Stay tuned! :)

https://codereview.appspot.com/108110044/