Re: Issue 3254: align unassociated lyrics using NoteColumn extent. (issue 108110044 by address@hidden)

[Janek Warchoł]

2014-06-27 8:05 GMT+02:00 Keith OHara <address@hidden>:
> On Thu, 26 Jun 2014 01:01:11 -0700, <address@hidden> wrote:
>
>> pushed as c73b41b3e7be6d7280c6336cf03610cd7aed3000 - thanks for review!
>> I'll post a follow-up patch later today.
>>
>> https://codereview.appspot.com/108110044/
>>
>
> It seems that after this patch, the old well-tested Devnull context should
> do everything that the new NullVoice does, without the complications and
> remaining problems.
>
> Do you also expect this to be true?   If you understand the full purpose of
> NullVoice and can check that Devnull fills the need, you might create a
> patch to make NullVoice a simple alias for Devnull (and reverse any patches
> related to NullVoice that we wouldn't otherwise want in the code).

Yeah, i also thought that this might be the case, but it turns out
that there was at least one more problem with lyrics attached to
devnull - see https://code.google.com/p/lilypond/issues/detail?id=248
- and my patch doesn't do anything about that.

However, looking at some bugs related to NullVoice, i have an
impression that it may be possible to improve its behaviour now, when
lyrics alignment is working better.  I'll try investigating, but i
cannot promise anything.

I'm also cc'ing Mark, who created NullVoice (are there more people who
could help here?)

best,
Janek