Re: Question about the new fret-label-horizontal-offset option

[James]

On 28/06/14 19:19, Thomas Morley wrote:
> 2014-06-28 18:05 GMT+02:00 James <address@hidden>:
>> Hello,
>>
>> I just want to check the following for the
>> 'fret-label-horizontal-offset' option we have added.
>>
>> --snip--
>>
>> \version "2.19.8"
>>
>> \new Voice {
>>   c''1^\markup {
>>     \override #'(fret-diagram-details . (
>>                  (fret-label-horizontal-offset . 0))) {
>>       \fret-diagram-verbose #'((mute 6)
>>                                (place-fret 5 3 1)
>>                                (place-fret 4 5 2)
>>                                (place-fret 3 5 3)
>>                                (place-fret 2 5 4)
>>                                (place-fret 1 3 1)
>>                                (barre 5 1 3))
>>     }
>>   }
>> }
>>
>> --snip--
>>
>> Here is what happens when I use '0' (zero)
>>
>>
>>
>> Here is what happens when I use 5
>>
>>
>>
>>
>> Here is what happens when I use -5
>>
>>
>> While these may not be the most reasonable examples, can I just check
>> that this is expected in that the fret label doesn't just offset but
>> changes (it seems) the whole dimension of the placement when using any
>> positive integer and if you use a negative integer that goes beyond the
>> width of the 'diagram' it pushes the diagram in the other way.
>>
>> Here is what happens when I use -15
>>
>>
>>
>> Thanks
>>
>> James
> Hi James,
>
> thanks for testing!
>
> It's expected behaviour, at least consistent with the behaviour of the
> (unchanged) `fret-label-vertical-offset'-property.
>
> See the output from the code below, test it with different values for
> 'fret-label-vertical-offset':
>
> \version "2.19.9"
>
> \new Voice {
>   c''1^\markup {
>     \override #'(fret-diagram-details . (
>                  (fret-label-horizontal-offset . 0))) {
>       \fret-diagram-verbose #'((mute 6)
>                                (place-fret 5 3 1)
>                                (place-fret 4 5 2)
>                                (place-fret 3 5 3)
>                                (place-fret 2 5 4)
>                                (place-fret 1 3 1)
>                                (barre 5 1 3))
>     }
>   }
>
>   \break
>
> %% taken from reg-test ‘fret-diagrams-landscape.ly’
> %% override for ‘fret-label-vertical-offset’ added
>   \override TextScript.fret-diagram-details.orientation = #'landscape
>   c'' ^\markup {
>     \override #'(fret-diagram-details . (
>                  (fret-label-vertical-offset . 15))) {
>       \fret-diagram-verbose #'((mute 6)
>                                (capo 3)
>                                (place-fret 4 5 1)
>                                (place-fret 3 5 2)
>                                (place-fret 2 5 3))
>     }
>   }
> }
>
> It might be worth fixing it, so that overrides for
> fret-label-horizontal/vertical-offset doesn't move the main
> fret-diagram.
> I've no good idea at the moment, though.
> Will think about it
>
>
> Thanks,
>   Harm
>
> P.S.
> I assume you intended to include some images, though your mail doesn't
> contain any, nor does
> http://lilypond.1069038.n5.nabble.com/Question-about-the-new-fret-label-horizontal-offset-option-td163746.html
> and
> http://lists.gnu.org/archive/html/lilypond-devel/2014-06/msg00147.html
> Though, I'm not friend with inline images at all. :)
Sorry, here they are attached and labeled accordingly.

James

offsetZero.png
Description: PNG image

offsetPlusFive.png
Description: PNG image

offsetMinusFive.png
Description: PNG image

offsetMinus15.png
Description: PNG image