lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Partcombiner documentation (Issue 4307) (issue 233110043 by address@


From: k-ohara5a5a
Subject: Re: Partcombiner documentation (Issue 4307) (issue 233110043 by address@hidden)
Date: Sun, 03 May 2015 05:19:13 +0000

Looks fine.


https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode937
Documentation/notation/simultaneous.itely:937: a second or more, setting
it to one splits notes of a third or more, and so one.
Extra 'e' on "and so on".

You might turn around the order of explanation so you don't have to
translate between interval names and number of scale steps, but just let
the example show it.

"A pair of numbers placed as an option after @code{\partcombine}
controls the range of intervals between the parts for which the
partcombiner may merge the parts.  The numbers in the pair specify the
number of scale-steps by which the first part is higher in pitch than
the second part.  The default range is from 0~steps (a unison) to
8~steps (a ninth)."

Dan wondered whether to make 2 represent a second, etc.,
 https://codereview.appspot.com/144170043/#msg14
but the code treats inverted intervals in a continuous way, so counting
scale steps seemed more natural.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode941
Documentation/notation/simultaneous.itely:941: c4 d e f |
Starting at a, will clarify what happens when the parts cross

https://codereview.appspot.com/233110043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]