lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Partcombiner documentation (Issue 4307) (issue 233110043 by address@


From: PhilEHolmes
Subject: Re: Partcombiner documentation (Issue 4307) (issue 233110043 by address@hidden)
Date: Sun, 03 May 2015 12:24:15 +0000

Thanks for the comments.


https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode931
Documentation/notation/simultaneous.itely:931: @notation{a due} note,
and separates notes more than a ninth apart into
On 2015/05/02 17:34:32, Trevor Daniels wrote:
For the avoidance of doubt, perhaps insert here:

@notation{a due} note, combines notes less than a ninth apart with the
same
rhythm as chords, and separates ...

Otherwise, LGTM.

Done.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode937
Documentation/notation/simultaneous.itely:937: a second or more, setting
it to one splits notes of a third or more, and so one.
On 2015/05/03 05:19:13, Keith wrote:
Extra 'e' on "and so on".

You might turn around the order of explanation so you don't have to
translate
between interval names and number of scale steps, but just let the
example show
it.

I decided to give examples of what value corresponded to what interval,
since the way it's been implemented actually seemed counterintuitive to
me and I had to check what was actually going on in my example.  Given
this, I thought being explicit was best.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode941
Documentation/notation/simultaneous.itely:941: c4 d e f |
On 2015/05/03 05:19:13, Keith wrote:
Starting at a, will clarify what happens when the parts cross

Done.

https://codereview.appspot.com/233110043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]