[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add stencil-flip function (issue 235090043 by address@hidden)
From: |
paulwmorris |
Subject: |
Re: Add stencil-flip function (issue 235090043 by address@hidden) |
Date: |
Wed, 06 May 2015 01:13:51 +0000 |
Thanks for the feedback! I've improved the doc strings, and revised the
doc string for ly:stencil-scale so that it covers negative arguments.
-Paul
https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly
File input/regression/stencil-scale.ly (right):
https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly#newcode8
input/regression/stencil-scale.ly:8: its bounding box.)"
On 2015/05/05 03:53:05, lemzwerg wrote:
Please use two spaces after a period that ends a sentence.
Thanks for the reminder.
https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly#newcode8
input/regression/stencil-scale.ly:8: its bounding box.)"
On 2015/05/05 04:16:37, Carl wrote:
I don't think information about stencil-flip should be put in this
regtest,
unless stencil-flip is also added to the regtest.
The headers of the regtests should only discuss the particular
regtest, in my
opinion.
Makes sense, and done.
https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm#newcode467
scm/stencil.scm:467: (is-absolute (if (memq head-raw
On 2015/05/05 04:16:38, Carl wrote:
Probably a nice touch, since absolute? is probably not really a
predicate.
Yep, just cleaning up after myself here.
https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm#newcode667
scm/stencil.scm:667: @var{axis} is 0 for X-axis, 1 for Y-axis."
On 2015/05/05 04:16:38, Carl wrote:
Perhaps you could also use X and Y instead of 0 and 1 (see the code
below where
you use X)
Done.
https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm#newcode667
scm/stencil.scm:667: @var{axis} is 0 for X-axis, 1 for Y-axis."
On 2015/05/05 03:53:05, lemzwerg wrote:
Can you somehow add the words `horizontally' and `vertically'?
Done.
Additionally, I
think it helps to tell the reader where the mirroring axis is
positioned.
I think I have this covered now, although with different wording.
https://codereview.appspot.com/235090043/
- Re: Add stencil-flip function (issue 235090043 by address@hidden), paulwmorris, 2015/05/04
- Re: Add stencil-flip function (issue 235090043 by address@hidden), lemzwerg, 2015/05/04
- Re: Add stencil-flip function (issue 235090043 by address@hidden), Carl . D . Sorensen, 2015/05/05
- Re: Add stencil-flip function (issue 235090043 by address@hidden),
paulwmorris <=
- Re: Add stencil-flip function (issue 235090043 by address@hidden), lemzwerg, 2015/05/06
- Re: Add stencil-flip function (issue 235090043 by address@hidden), thomasmorley65, 2015/05/06
- Re: Add stencil-flip function (issue 235090043 by address@hidden), paulwmorris, 2015/05/07
- Re: Add stencil-flip function (issue 235090043 by address@hidden), lemzwerg, 2015/05/07
- Re: Add stencil-flip function (issue 235090043 by address@hidden), paulwmorris, 2015/05/07
- Re: Add stencil-flip function (issue 235090043 by address@hidden), pkx166h, 2015/05/12
- Re: Add stencil-flip function (issue 235090043 by address@hidden), pkx166h, 2015/05/16
- Re: Add stencil-flip function (issue 235090043 by address@hidden), pkx166h, 2015/05/17