lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add stencil-flip function (issue 235090043 by address@hidden)


From: Carl . D . Sorensen
Subject: Re: Add stencil-flip function (issue 235090043 by address@hidden)
Date: Tue, 05 May 2015 04:16:37 +0000

Looks good!  Thanks for posting it.  A couple of comments included.



https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly
File input/regression/stencil-scale.ly (right):

https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly#newcode8
input/regression/stencil-scale.ly:8: its bounding box.)"
I don't think information about stencil-flip should be put in this
regtest, unless stencil-flip is also added to the regtest.

The headers of the regtests should only discuss the particular regtest,
in my opinion.

https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm#newcode467
scm/stencil.scm:467: (is-absolute (if (memq head-raw
Probably a nice touch, since absolute? is probably not really a
predicate.

https://codereview.appspot.com/235090043/diff/1/scm/stencil.scm#newcode667
scm/stencil.scm:667: @var{axis} is 0 for X-axis, 1 for Y-axis."
Perhaps you could also use X and Y instead of 0 and 1  (see the code
below where you use X)

https://codereview.appspot.com/235090043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]