Fretboards: markup strings in dot positions (issue 238180043 by address@hidden)

[thomasmorley65]

Reviewers: ,

Description:
Fretboards: markup strings in dot positions

Issue 4120

Fixes disappeared strings, restores the behaviour before the fix
for Issue 2752

Does not scale those strings, though, in order to fix the regression
first
and do other feature requests for issue 4120 in a follow up.

Please review this at https://codereview.appspot.com/238180043/

Affected files (+6, -5 lines):
  M scm/fret-diagrams.scm


Index: scm/fret-diagrams.scm
diff --git a/scm/fret-diagrams.scm b/scm/fret-diagrams.scm
index  
74ab65fedd0788fb29e79e712a8d4afec45431f8..f8ccb59a111886ce250590d822c6f7bb9624aa6e  
100644
--- a/scm/fret-diagrams.scm
+++ b/scm/fret-diagrams.scm
@@ -109,11 +109,12 @@ to end-point."
                   (car this-list)
                 ;; fret
                   (- (second this-list) base-fret)
-                ;; finger
-                  (if (or (null? (cddr this-list))
-                        (not (number? (caddr this-list))))
-                      '()
-                      (third this-list))
+                ;; finger-number or markup
+                  (if (and (not (null? (cddr this-list)))
+                           (or (markup? (caddr this-list))
+                               (number? (caddr this-list))))
+                      (third this-list)
+                      '())
                 ;; inverted
                   (dot-is-inverted this-list)
                 ;; parenthesis