[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] Remove parser/location global variable setup
From: |
David Kastrup |
Subject: |
Re: [PATCH 1/5] Remove parser/location global variable setup |
Date: |
Wed, 27 May 2015 14:00:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Dan Eble <address@hidden> writes:
> On May 27, 2015, at 05:45 , David Kastrup <address@hidden> wrote:
>>
>> +(define %parser (make-fluid))
>> +(define %location (make-fluid))
>
>> +(define-public (*parser*) (fluid-ref %parser))
>> +(define-public (*location*) (fluid-ref %location))
>
> Are the decorations on these names ad-hoc or are you following a
> convention? (I’m asking for my own edification.)
We are using them for parameters/accessors elsewhere:
address@hidden:/usr/local/tmp/lilypond$ git grep '(\*[a-z]\+\*)' origin
origin:Documentation/misc/ChangeLog-2.10: (*parser*) lookup if (*parser*)
!= #f.
origin:scm/define-music-display-methods.scm: (if force-line-break (+
2 (*indent*)) 1)
origin:scm/define-music-display-methods.scm: (parameterize
((*indent* (+ 2 (*indent*))))
origin:scm/define-music-display-methods.scm: (if force-line-break
(*indent*) 1))))
origin:scm/define-music-display-methods.scm: (parameterize ((*indent* (+ 3
(*indent*))))
origin:scm/define-music-display-methods.scm:
(parameterize ((*indent* (+ (*indent*) 2)))
origin:scm/define-music-display-methods.scm:
(*indent*)
origin:scm/define-music-display-methods.scm: (*indent*)))
origin:scm/display-lily.scm: (format #f "~%~v_" (max 0 (1- (*indent*)))))
origin:scm/song.scm: #:unfinished (and (not (*syllabify*))
(find-child-named music 'HyphenEvent))
Doing a bit of web searching, I haven't been able to find use of this
convention outside of LilyPond.
--
David Kastrup
- [PATCH 1/5] Remove parser/location global variable setup, David Kastrup, 2015/05/27
- [PATCH 2/5] Fix various jumbled parser/location argument pairs, David Kastrup, 2015/05/27
- [PATCH 3/5] Remove parser/location args from music function calls, David Kastrup, 2015/05/27
- [PATCH 4/5] convert-ly rule for removing parser/location, David Kastrup, 2015/05/27
- [PATCH 5/5] Run scripts/auxiliar/update-with-convert-ly.sh, David Kastrup, 2015/05/27
- Re: [PATCH 1/5] Remove parser/location global variable setup, David Kastrup, 2015/05/27
- Re: [PATCH 1/5] Remove parser/location global variable setup, Dan Eble, 2015/05/27