Re: fret-diagram with barre returns weird output (issue 247750043 by address@hidden)

[thomasmorley65]

On 2015/06/11 11:53:53, dak wrote:
> I just hate it when I find that a "Draft" of mine was "Unpublished".
This is
> really something that happens all the time when I am using Rietveld.

Thanks for uploading the patch and the review!


> https://codereview.appspot.com/247750043/diff/1/scm/fret-diagrams.scm
> File scm/fret-diagrams.scm (right):


https://codereview.appspot.com/247750043/diff/1/scm/fret-diagrams.scm#newcode266
> scm/fret-diagrams.scm:266: (set! minfret (apply min (cons minfret (map
last
> barre-list)))))
> Instead of (apply min (cons minfret (map last barre-list))) one can
just write
> (apply min minfret (map last barre-list))
> since apply will just retain all arguments except the last one (which
is
> interpreted as a list of further arguments).


Done locally.

Any objections that I push it directly to staging or is a new
review-circle needed/wanted?

https://codereview.appspot.com/247750043/