|
From: | lemzwerg |
Subject: | Re: Define default fonts in fontconfig configuration file (issue 241340043 by address@hidden) |
Date: | Thu, 11 Jun 2015 22:12:33 +0000 |
Nice! LGTM. https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc#newcode60 lily/font-config.cc:60: confs.push_back (lilypond_datadir + "/fonts/lilypond-fonts.conf"); This line adds one .conf file, right? So... https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc#newcode62 lily/font-config.cc:62: for (vsize i = 0; i < confs.size (); i++) ... do we have a loop here? https://codereview.appspot.com/241340043/
[Prev in Thread] | Current Thread | [Next in Thread] |