Re: Auto_change_iterator no longer creates staff contexts itself. They are created in scheme. (issue 249970043 by address@hidden)

[thomasmorley65]

https://codereview.appspot.com/249970043/diff/1/scm/define-context-properties.scm
File scm/define-context-properties.scm (left):

https://codereview.appspot.com/249970043/diff/1/scm/define-context-properties.scm#oldcode179
scm/define-context-properties.scm:179: (bassStaffProperties ,list? "An
alist of property settings to
On 2015/06/27 18:54:03, Dan Eble wrote:
> It would be responsible of me to draw attention to this.  I have
simply removed
> bassStaffProperties and trebleStaffProperties.  The NR section on
\autochange
> does not mention them, so I concluded that they were intended for
internal use
> only.  I hope there are no problems with this.


Thanks pointing to it again. I already stumbled upon it, though, maybe
I'd have forgotten to reply.


bassStaffProperties and trebleStaffProperties are not really documented,
though I'd call it more a documentation issue.

There are use-cases thinkable, like:

\new PianoStaff
\with {
  trebleStaffProperties =
    #'((assign clefGlyph "clefs.C")   
       (assign clefPosition 0)
       (assign middleCPosition -5)
       (assign middleCClefPosition -5))
}

{
  \autochange {
    g4 a b c'
    d'4 r a g
  }
}

I vote for keeping them, although I think it's a very cumbersome method
to specify which clefs the PianoStaff should use.

https://codereview.appspot.com/249970043/