[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Auto_change_iterator: move some state from C++ to Scheme (issue 2484
|
From: |
thomasmorley65 |
|
Subject: |
Re: Auto_change_iterator: move some state from C++ to Scheme (issue 248470043 by address@hidden) |
|
Date: |
Mon, 29 Jun 2015 09:03:56 +0000 |
Some remarks.
Not related to your changes, though, why not fix them, when you're
already on it?
https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm
File scm/autochange.scm (right):
https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm#newcode2
scm/autochange.scm:2:
This file is missing the usual remarks about license,
https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm#newcode38
scm/autochange.scm:38: (m1 (make-non-relative-music (context-spec-music
music 'Voice "one")))
If I'm not mistaken the local variable 'm1' isn't used. Delete his
line!?
https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm#newcode41
scm/autochange.scm:41: (evs (car context-list))
same with 'evs'
https://codereview.appspot.com/248470043/