[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Auto_change_iterator: move some state from C++ to Scheme (issue 2484
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: Auto_change_iterator: move some state from C++ to Scheme (issue 248470043 by address@hidden) |
|
Date: |
Mon, 29 Jun 2015 12:23:36 +0000 |
https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm
File scm/autochange.scm (right):
https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm#newcode38
scm/autochange.scm:38: (m1 (make-non-relative-music (context-spec-music
music 'Voice "one")))
On 2015/06/29 09:03:56, thomasmorley651 wrote:
If I'm not mistaken the local variable 'm1' isn't used. Delete his
line!?
Another possibility is that it was intended to be used, but by mistake
it wasn't, so that there are undiscovered bugs.
I'll try to consider this later today, but I'm not promising to change
anything.
Thanks for your review.
https://codereview.appspot.com/248470043/