Re: Recent checkins break 'make' on staging

[David Kastrup]

James <address@hidden> writes:

> Hello,
>
> I just pushed two Patches on behalf of Paul (they are currently at
> HEAD:staging) and now I cannot get past 'make'.
>
> The log shows this:
>
> --snip--
>
> make[1]: *** [out/page-breaking-scheme.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> /tmp/lilypond-autobuild/lily/page-breaking.cc: In member function
> 'scm_unused_struct* Page_breaking::make_pages(std::
> vector<long unsigned int>, SCM)':
> /tmp/lilypond-autobuild/lily/page-breaking.cc:614:24: warning:
> conversion to 'int' from 'vsize {aka long unsigned int
> }' may alter its value [-Wconversion]
>        int page_num = i + first_page_number;
>                         ^
> /tmp/lilypond-autobuild/lily/page-breaking.cc:617:55: warning:
> conversion to 'scm_t_int32 {aka int}' from 'long unsig
> ned int' may alter its value [-Wconversion]
>        SCM line_count = scm_from_int (lines_per_page[i]);
>
> etc.

The warnings are a nuisance and should be fixed by Paul by, well, using
the correct types.

However, those warnings are produced _after_ (one run of) GCC has
already aborted (on lily/page-breaking-scheme.cc rather than
lily/page-breaking.cc), when the remaining jobs are finishing.  The
error messages triggering _that_ should occur before that.

> Can someone help? Or perhaps remove these entries from staging for the
> time being?

I'll back out issue 4752 and let you cater for further cleanup.  Holler
if further help is needed.


-- 
David Kastrup