[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: When to start patch review
|
From: |
Urs Liska |
|
Subject: |
Re: When to start patch review |
|
Date: |
Wed, 17 Feb 2016 17:49:09 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
Am 17.02.2016 um 17:47 schrieb Simon Albrecht:
>> Waiting for a patch like that to pass before review is pointless if
>> there is going to be a reluctance or even refusal to allow it to make
>> it to master in the end.
>>
>> However, is there a particular reason for this question?
>
> No, just a thought I had. And what you say is good, so it’s clear now.
>
> Best, Simon
>
Starting review before the status is set to review just keeps a certain
risk that a test failure might make your reviewing work obsolete.
Urs