Re: Embed LilyPond source files inside generated PDF (issue 225040043 by address@hidden)

[v . villenave]

OK, new version.  The new "fluid" parser variable is noticeably nicer to
work with than what we had before.


https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc
File lily/sources.cc (right):

https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc#newcode93
lily/sources.cc:93: (SCM parser_smob),
On 2016/02/28 14:09:51, dak wrote:
> Maybe make the parser_smob argument optional?  It can be deduced via
the %parser
> fluid in the same manner a number of other functions do.

Done.

https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc#newcode107
lily/sources.cc:107: return scm_reverse (lst);
On 2016/02/28 14:09:51, dak wrote:
> I'd use scm_reverse_x (lst, SCM_EOL) here since you built the list
completely
> yourself, so there is no point in copying it for reversal.

Done.

https://codereview.appspot.com/225040043/diff/120001/scm/framework-ps.scm
File scm/framework-ps.scm (right):

https://codereview.appspot.com/225040043/diff/120001/scm/framework-ps.scm#newcode468
scm/framework-ps.scm:468: (format "% LilyPond source file: ~a\n\n"
filename))
While I find it wise to add something here in case someone
having downloaded the PDF would wonder what these embedded
files are, I’m not entirely sure if it’s wise to alter the
source file. Thoughts?

https://codereview.appspot.com/225040043/diff/120001/scm/framework-ps.scm#newcode504
scm/framework-ps.scm:504: (ps-quote
On 2016/02/28 14:09:51, dak wrote:
> It's that simple?  Wow.

Yeah, it’s pretty neat. We can thank Bertrand and Reinhold:
http://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=ee02cd08e6bf81884323809241013c1834b413ed
http://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=dffe04e8e1a7c0b94fdfc30e44fe141dfbe7cbec

https://codereview.appspot.com/225040043/