Re: Define French as a separate input language (issue 288290043 by address@hidden)

[v . villenave]

On 2016/02/28 12:18:29, dak wrote:
> It seems to me (after glancing over it) like the last Rietveld review
was just
> abandoned and the same state resubmitted.

Greetings David,
not entirely.  I’ve removed the pointless convert-rules, among others.

> Any reason the suggestions have not been addressed?

I did (try to) address them in the previous discussion.
tl,dr: accepting both "espanol" and "español" but only "français" seemed
inconsistent to me (even though, I know, there are two justifications
for "espanol" that "francais" doesn’t have).

That being said, I’m obviously in no place to make my point, so: there
you go.


https://codereview.appspot.com/288290043/diff/40001/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/288290043/diff/40001/python/musicexp.py#newcode282
python/musicexp.py:282: "francais": pitch_francais,
On 2016/02/28 12:18:29, dak wrote:
> Why "francais" here instead of "français"?

Done.

https://codereview.appspot.com/288290043/diff/40001/scm/define-note-names.scm
File scm/define-note-names.scm (right):

https://codereview.appspot.com/288290043/diff/40001/scm/define-note-names.scm#newcode555
scm/define-note-names.scm:555: (francais . (
On 2016/02/28 12:18:29, dak wrote:
> français seems permitted as a symbol name in both Guile-1.8 and
Guile-2.0.

I’m not sure we use non-ascii symbol names or variables anywhere else in
LilyPond’s codebase. Granted, defining it as an alias doesn’t help
anyway.

https://codereview.appspot.com/288290043/