[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: add choral and choral-cautionary accidental style (issue 311430043 b
|
From: |
thomasmorley65 |
|
Subject: |
Re: add choral and choral-cautionary accidental style (issue 311430043 by address@hidden) |
|
Date: |
Wed, 14 Dec 2016 14:13:11 -0800 |
Worth an entry in changes?
Some wording-nitpicks, otherwise
LGTM
https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely#newcode2210
Documentation/notation/pitches.itely:2210: style. It is intended for
editions that are used both by singers that only
The wording feels not very elegant.
Though, I'm a non-native speaker...
https://codereview.appspot.com/311430043/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/311430043/diff/1/scm/music-functions.scm#newcode1847
scm/music-functions.scm:1847: ;; that the first alteration within a
voice (as opposed to on the
wording again, maybe:
Similar to piano, except that the first alteration within a voice is
always printed (as opposed to within a staff).
But again: non-native-speaker
https://codereview.appspot.com/311430043/