Re: add choral and choral-cautionary accidental style (issue 311430043 by address@hidden)

[Alexander Kobel]

On 2016-12-14 23:13, address@hidden wrote:
> Worth an entry in changes?

Maybe. Doesn't need a lot, I guess; something like
"Accidental rules can now be defined across ChoirStaff contexts. Two new 
rules choral and choral-cautionary are available that combine the 
characteristics of modern-voice and piano or their equivalents with 
cautionary accidentals."

> Some wording-nitpicks, otherwise
> LGTM

Thanks.

> https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely#newcode2210
>
> Documentation/notation/pitches.itely:2210: style. It is intended for
> editions that are used both by singers that only
> The wording feels not very elegant.
> Though, I'm a non-native speaker...

Not a native speaker here, either, so I'm open to proposals.

> https://codereview.appspot.com/311430043/diff/1/scm/music-functions.scm#newcode1847
>
> scm/music-functions.scm:1847: ;; that the first alteration within a
> voice (as opposed to on the
> wording again, maybe:
> Similar to piano, except that the first alteration within a voice is
> always printed (as opposed to within a staff).

Agreed, that sounds better.


Cheers,
Alexander