[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: adding a snippet to a patch
From: |
David Nalesnik |
Subject: |
Re: adding a snippet to a patch |
Date: |
Mon, 9 Jan 2017 15:51:40 -0600 |
On Mon, Jan 9, 2017 at 2:00 PM, David Nalesnik <address@hidden> wrote:
> Hi,
>
> I'm adding a snippet to a patch dealing with hairpins, and I'm not
> sure what I need to do.
>
> I've added the snippet to Documentation/snippets/new.
>
> Do I then need to run scripts/auxiliar/makelsr.py and add the
> resulting files to my patch for upload to Rietveld?
>
> The reason I ask is that there is a snippet not my own which is
> getting written to Documentation/snippets/ when I run the script:
> using-marklines-in-a-frenched-score.ly. This leads to changes in
> Documentation/snippets/staff-notation.snippet-list as well.
>
> I don't want these changes jumbled in with my patch.
Looking over several older patches affecting snippets, I see that I
should run the makelsr script and add the resulting files.
This, however, was not done in the last patch adding a snippet:
commit 5944d20489bb5b8e4c4907fa3b3bcae9ec275ccb
Author: Mark Knoop <address@hidden>
Date: Thu Sep 8 18:56:16 2016 +0100
I'm at a loss what to do. Should I just add the files relevant to my
patch, and ignore those produced by Mark's?
Thanks,
David