[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Automatic LyricExtenders (issue 313240043 by address@hidden)
|
From: |
Knut Petersen |
|
Subject: |
Re: Automatic LyricExtenders (issue 313240043 by address@hidden) |
|
Date: |
Wed, 18 Jan 2017 17:06:38 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
Am 18.01.2017 um 09:28 schrieb address@hidden:
https://codereview.appspot.com/313240043/diff/160001/lily/parser.yy
File lily/parser.yy (right):
https://codereview.appspot.com/313240043/diff/160001/lily/parser.yy#newcode3107
lily/parser.yy:3107: $$ = $1;
That looks like strange fallback behavior. EXTENDER likely has a value
of SCM_UNSPECIFIED (at least I think that is the default for tokens
without attached value). Can the containing expression deal with that?
I actually had SCM_UNSPECIFIED without the warning in patchset 4 ... don't know
why I changed it. Surprisingly both work identically. But yes, it should be
SCM_UNSPECIFIED.
Knut
0001-fix-parser-cosmetics.patch
Description: Text Data