[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Automatic LyricExtenders (issue 313240043 by address@hidden)
|
From: |
dak |
|
Subject: |
Re: Automatic LyricExtenders (issue 313240043 by address@hidden) |
|
Date: |
Mon, 30 Jan 2017 07:11:21 -0800 |
https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc
File lily/self-alignment-interface.cc (right):
https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc#newcode61
lily/self-alignment-interface.cc:61: return scm_from_double (-
ext.linear_combination (scm_to_double (align)));
On 2016/12/25 17:25:26, david.nalesnik wrote:
Grobs are recognized by their interfaces not their names. So here you
would
write !has_interface<Lyric_syllable_interface> (me)
(I confess I'm unclear when internal_has_interface is used, though.)
When has_interface does not work because the type cannot be determined
at runtime?
But this case appears icky. Why would we have a non-empty glyph with
empty extents here in the first place? Shouldn't it be removed earlier?
https://codereview.appspot.com/313240043/