[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Let \alterBroken tweak ties again (issue 319160043 by address@hidden
|
From: |
david . nalesnik |
|
Subject: |
Re: Let \alterBroken tweak ties again (issue 319160043 by address@hidden) |
|
Date: |
Mon, 23 Jan 2017 14:49:39 -0800 |
On 2017/01/23 19:00:43, david.nalesnik wrote:
No problem.
https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107
ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item
'span-direction) START)
On 2017/01/23 18:24:29, dak wrote:
> This may be stupid, but as long as we are touching the code, we
might as well
> make it correct. Numbers may not reliably be compared with eq? but
require
use
> of eqv? instead.
Done.
I get 18 instances with the following (misses variables storing numbers,
of course):
git grep
"(eq?\s\+\((.\+)\|[A-Za-z-]\+\)\s\+\(-\?[[:digit:]]\+\|X\|Y\|LEFT\|RIGHT\|
UP\|DOWN\))"
Probably worth a patch.
https://codereview.appspot.com/319160043/