[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 3830: Document \offset command (issue 319150043 by address@hid
From: |
thomasmorley65 |
Subject: |
Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden) |
Date: |
Mon, 23 Jan 2017 15:52:54 -0800 |
Two thoughts, otherwise
LGTM
https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522
Documentation/notation/changing-defaults.itely:2522: [-]\offset
@var{property} @var{offsets} @var{item}
Would it be even more clear to have instead of @var{offsets} something
like @var{offset-value} or @var{property-value}?
(Same below and in the docstring for the offset-command in
music-functions-init.ly)
Please keep in mind I'm not a native speaker, so I may be wrong here.
https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2539
Documentation/notation/changing-defaults.itely:2539: @code{\once} or
@code{\temporary} and reverted by using @code{\revert}
Does \undo work?
If so, please mention it as well.
https://codereview.appspot.com/319150043/
- Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/22
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), simon . albrecht, 2017/01/23
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden),
thomasmorley65 <=
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/24
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), pkx166h, 2017/01/24
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/24
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/24
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/24
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/24
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/25
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), simon . albrecht, 2017/01/25
- Re: Issue 3830: Document \offset command (issue 319150043 by address@hidden), david . nalesnik, 2017/01/26