lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Create engravers for merging rests (issue 321930043 by address@hidde


From: thomasmorley65
Subject: Re: Create engravers for merging rests (issue 321930043 by address@hidden)
Date: Sat, 20 May 2017 05:18:33 -0700

Much better now, though:


https://codereview.appspot.com/321930043/diff/100001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/321930043/diff/100001/scm/scheme-engravers.scm#newcode151
scm/scheme-engravers.scm:151: (define (rest-eqv rest-len-prop)
The current patch-set fails with:
"Variable used before given a value: rest-eqv"
because subsequent usage of 'define ...' is equivalent to let not let*

Moving (define (rest-eqv rest-len-prop) before the engraver-definiton
starts will work or something at the lines of

...
  (let* ((rest-eqv
           (lambda (rest-len-prop)
             (define (rest-len rest) (ly:grob-property rest
rest-len-prop))
             (lambda (rest-a rest-b)
               (eqv? (rest-len rest-a) (rest-len rest-b)))))
         (mmrest-same-length (rest-eqv 'measure-count))
         (rest-same-length (rest-eqv 'duration-log)))

  (define (merge-mmrests rests)
...

https://codereview.appspot.com/321930043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]