Re: Create engravers for merging rests (issue 321930043 by address@hidden)

[thomasmorley65]

I think this one warrants an entry in changes.


https://codereview.appspot.com/321930043/diff/140001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/321930043/diff/140001/scm/scheme-engravers.scm#newcode152
scm/scheme-engravers.scm:152: (define (rests-all-unpitched rests)
This will catch not only pitched rests, but also rests where the user
has set Rest.staff-position.
I tend to agree with it, although rests where the user changed 'Y-offset
or 'extra-offset are not taken into account. We can't foresee any of
those possibilities, anyway.

Though, I would insert a comment about it for future developers working
on it.

In general, why do you use a recursion?
(every (lambda (r) (null? (ly:grob-property r 'staff-position))) rests)
looks at least shorter

https://codereview.appspot.com/321930043/