lilypond-user
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Re: not-so-ancient flags


From: Reinhold Kainhofer
Subject: [PATCH] Re: not-so-ancient flags
Date: Thu, 24 Jul 2008 19:33:58 +0200
User-agent: KMail/1.9.9

Am Donnerstag, 24. Juli 2008 schrieb luis jure:
> on 2008-07-24 at 08:14 madhg wrote:
> >1) personally I like the flags in the first row of my June 17 message
> >in this thread.  As you say it's a matter of taste.
>
> i'd like to promote the inclusion of TWO new flags, something like
> straight-ancient and straight-modern. 

I'll leave that to Han-Wen or Werner to decide...

Attached is a patch to implement straight flags (in modern style, i.e. slanted 
only ~20 degrees). I think the angles (different angles for up/down stems!) 
and the lengths are okay, although they might still be fine-tuned a bit more.

I've also fixed the issue with acciaccaturas (in the way I described in my 
previous mail: I added flags.straightugrace and modified stem.cc to use a 
glyph that does also contain the flag style, i.e. flags.straightugrace, but 
fall back to flags.ugrace if such a flag-style-specific grace glyph does not 
exist). However, I didn't find the exact cause of my second problem, where 
the flags do not start at the very end of the stem, but are shifted a little 
inwards... To see this problem, look at the attached sample file: In the 
second line (the down stems) the flags do not line up exactly with the end of 
the stem :(

I'm also attaching a test file to show the different flag styles.

Any comments? Okay to apply to master?

Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/

Attachment: 0001-Feature-Implement-straight-flags-add-grace-slash-f.patch
Description: Text Data

Attachment: straight-flags.pdf
Description: Adobe PDF document

Attachment: straight-flags.ly
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]