[lmi-commits] [lmi] odd/multiarch 84ef873 02/16: Document some architecture-selection alternatives

[Greg Chicares]

branch: odd/multiarch
commit 84ef873a7fa71556af97387666a4f41a72c45864
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Document some architecture-selection alternatives
---
 gui_test.sh          | 11 ++++++++++-
 nychthemeral_test.sh | 11 ++++++++---
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/gui_test.sh b/gui_test.sh
index 4481f99..7862816 100755
--- a/gui_test.sh
+++ b/gui_test.sh
@@ -142,6 +142,15 @@ mkdir --parents /tmp/lmi/logs
 cd /opt/lmi/src/lmi
 
 # NOT! "$PERFORM" /opt/lmi/"$LMI_HOST"/bin/wx_test --ash_nazg 
--data_path=/opt/lmi/data 2>&1 | tee /tmp/lmi/logs/gui-test | sed -e 
"$gui_test_clutter"
+#
 # Specifying the "true" path to a binary too often requires setting
-# $PATH and $WINEPATH, which is complex and fragile; symlinks are much better.
+# $PATH and $WINEPATH, which is complex and fragile; symlinks are much
+# better. Alternatively, sourcing 'set_arch.sh' here:
+# . ./set_arch.sh
+# would be sure to do something reliably, though perhaps not quite
+# what was intended--e.g., if the 'set_arch.sh' environment is for
+# one architecture, but a GUI test of another architecture is wanted.
+# Perhaps best of all would be to source a 'test_arch.sh' script here
+# that would return nonzero if the environment doesn't consistently
+# designate a single architecture.
 "$PERFORM" /opt/lmi/bin/wx_test --ash_nazg --data_path=/opt/lmi/data 2>&1 | 
tee /tmp/lmi/logs/gui-test | sed -e "$gui_test_clutter"
diff --git a/nychthemeral_test.sh b/nychthemeral_test.sh
index 656532c..cb783f9 100755
--- a/nychthemeral_test.sh
+++ b/nychthemeral_test.sh
@@ -23,9 +23,14 @@
 
 # Suggested use:
 # [It seems moderately distasteful to insert "$(LMI_HOST)/" here,
-# and maybe some bad thing would happen if $LMI_HOST is not defined;
-# but is there any cleaner way to do this? Would it be worthwhile
-# to set up a symlink for /tmp/lmi/$(LMI_HOST) ?
+# but is there any cleaner way to do this? Adding something like
+#   export NYCHTHEMERAL_TEST_DIR="/tmp/lmi/$(LMI_HOST)"
+# to 'set_arch.sh' can't be right; setting up a symlink can't be
+# any better. Perhaps a subdirectory of 'prefix' should be used
+# instead of 'tmp'? Or should this script instead be...
+#  - called only through a driver that sets "$logdir"?
+#  - refactored as a script function, invoked after setting "$logdir"?
+#  - used preferably as a makefile target that sets "$logdir"?
 #   $make clobber; ./nychthemeral_test.sh 2>&1 | tee 
/tmp/lmi/$(LMI_HOST)/logs/log | sed -f errors.sed
 # Omitting the 'clobber' step when it's known to be unnecessary makes
 # that command take two minutes instead of five on a dual E5-2630 v3