lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] odd/multiarch daee5d2 06/16: Remove commentary that


From: Greg Chicares
Subject: [lmi-commits] [lmi] odd/multiarch daee5d2 06/16: Remove commentary that is no longer useful
Date: Wed, 10 Apr 2019 22:15:07 -0400 (EDT)

branch: odd/multiarch
commit daee5d2254b83103c4bc01cf02e2213822969789
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Remove commentary that is no longer useful
    
    Determining build type by running each library's 'config.guess' is
    canonical and requires no comment.
---
 install_libxml2_libxslt.make | 9 ---------
 install_wx.sh                | 2 --
 2 files changed, 11 deletions(-)

diff --git a/install_libxml2_libxslt.make b/install_libxml2_libxslt.make
index 998a0b6..001d6b3 100644
--- a/install_libxml2_libxslt.make
+++ b/install_libxml2_libxslt.make
@@ -61,18 +61,9 @@ xml_dir       := /opt/lmi/$(host_type)/xml-scratch
 # Variables that normally should be left alone 
#################################
 
 mingw_bin_dir :=
-#   cache the value in $LMI_BUILD, or always invoke 'config.guess'?
-# This build_type is overridden below for cygwin; is there no good
-# way to get it dynamically, OAOO, except 'config.guess', which may
-# not be globally available?
-# expunge build_type    := $(if $(LMI_BUILD),$(LMI_BUILD),x86_64-pc-linux-gnu)
 
-# also review all occurrences of 'PERFORM'
 ifeq (cygwin,$(findstring cygwin,$(LMI_BUILD)))
   mingw_bin_dir := $(mingw_dir)/bin/
-# In the future..."x86_64-pc-cygwin" would be correct;
-# but it's future-proof to use 'config.guess'.
-# expunge  build_type    := i686-pc-cygwin
 endif
 
 xz_cflags := \
diff --git a/install_wx.sh b/install_wx.sh
index 08143dd..ab69a2d 100755
--- a/install_wx.sh
+++ b/install_wx.sh
@@ -79,8 +79,6 @@ git checkout "$wx_commit_sha"
 # Get any new submodules that may have been added, even if nested.
 git submodule update "$coefficiency" --recursive --init
 
-# This should be equivalent to $LMI_BUILD, but it's better to use the
-# library's own 'config.guess'.
 build_type=$("$proxy_wx_dir"/config.guess)
 
 case "$build_type" in



reply via email to

[Prev in Thread] Current Thread [Next in Thread]